resolve flaky ChunkLinkDownloadServiceTest.testBatchDownloadChaining …#842
Merged
Merged
Conversation
…in CI The test was intermittently failing on GitHub Actions with getResultChunks() being called 3 times instead of the expected 1 time, while consistently passing locally. Root cause: - Race condition between concurrent getLinkForChunk() calls and expired link detection - Test used expiration date "2025-02-16T00:00:00Z" which could be considered expired depending on SECONDS_BUFFER_FOR_EXPIRY and timing - When multiple threads detected expired links, they triggered multiple reset operations - Different thread scheduling between local Mac and GitHub Actions runners exposed the issue Changes: - Use far future expiration dates (2030-12-31) to prevent unintended link expiration
gopalldb
reviewed
Jun 1, 2025
vikrantpuppala
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…in CI
NO_CHANGELOG=true
Description
The test was intermittently failing on GitHub Actions with getResultChunks() being called 3 times instead of the expected 1 time, while consistently passing locally.
Root cause:
Changes:
Testing
Additional Notes to the Reviewer